netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH -next] netfilter: conntrack: remove timer from ecache extension
Date: Fri, 28 Mar 2014 14:09:34 +0100	[thread overview]
Message-ID: <20140328130934.GB4682@breakpoint.cc> (raw)
In-Reply-To: <20140328111440.GA12728@localhost>

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Fri, Mar 28, 2014 at 12:10:31PM +0100, Florian Westphal wrote:
> > Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > > >  I'm mainly interested if you think timer removal is worthwile,
> > > >  it works well in practice from usability POV.
> > > 
> > > Thanks for looking again into this. We definitely have to get rid of
> > > that timer.
> > > 
> > > Regarding the new flag, perhaps we can avoid exposing this to
> > > userspace? I mean, we can define some mask of internal flags that we
> > > don't include via dump_status in ctnetlink.
> > 
> > What is your rationale for supressing this information?
> > [ or, why is exposing this to userspace bad? ]
> 
> I think that flag provides no useful information to userspace.

Fair enough.

> > Is it so we don't have to keep dummy flag when we find a different
> > solution later?
> 
> Right, that's another good reason not to expose that information to
> userspace.

Alright, I'll create a separate patch that adds mask of 'public'
flags that will be dumped to userspace.

Will send it along with another spin of this patch next week or so.

      reply	other threads:[~2014-03-28 13:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-27 18:00 [PATCH -next] netfilter: conntrack: remove timer from ecache extension Florian Westphal
2014-03-28 10:32 ` Pablo Neira Ayuso
2014-03-28 11:10   ` Florian Westphal
2014-03-28 11:14     ` Pablo Neira Ayuso
2014-03-28 13:09       ` Florian Westphal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140328130934.GB4682@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).