From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] netfilter: xt_nfacct: Add quota to nfacct filter
Date: Mon, 31 Mar 2014 17:17:30 +0200 [thread overview]
Message-ID: <20140331151730.GA19050@localhost> (raw)
In-Reply-To: <CANLsYky5ciqKEP7oNuP1bEdX3iARKHtDgv=87j8dFXjTCt255Q@mail.gmail.com>
On Mon, Mar 31, 2014 at 07:50:06AM -0600, Mathieu Poirier wrote:
[...]
> >
> > You can just define some enum, ie.
> >
> > enum {
> > NFACCT_NO_QUOTA = -1,
> > NFACCT_UNDERQUOTA,
> > NFACCT_OVERQUOTA,
> > };
> >
> > to include/linux/netfilter/nfnetlink_acct.h.
> >
> > I guess with that we can also remove the comments everywhere, as it
> > will be quite clear with the enums.
> >
> > Merge window will be close soon, please also post the userspace
> > changes for the library and the utility asap.
>
> At this time I only have the userspace modifications in the nfacct
> port I did for Android. That one links to libnl2.0 and won't be of
> interest to you. I can get you the kernel work in time for the merge
> window but modifications to the "real" nfacct may not make it. I'd
> love to see the work going in the 3.15 merge window but can't offer
> guarantees.
>
> Would you consider queuing the kernel patch in the merge window
> without the userspace? Note that I would understand if you woudn't
> accept that....
You have to send me the library changes for libnetfilter_acct at
least and the tested kernel patch asap.
prev parent reply other threads:[~2014-03-31 15:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-30 21:10 [RFC PATCH 0/2] netfilter: Adding quota capabilities to nfnetlink mathieu.poirier
2014-03-30 21:10 ` [RFC PATCH 1/2] netfilter: nfnetlink_acct: Adding quota support to nf_acct objects mathieu.poirier
2014-03-30 21:10 ` [RFC PATCH 2/2] netfilter: xt_nfacct: Add quota to nfacct filter mathieu.poirier
2014-03-31 12:13 ` Pablo Neira Ayuso
2014-03-31 13:50 ` Mathieu Poirier
2014-03-31 15:17 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140331151730.GA19050@localhost \
--to=pablo@netfilter.org \
--cc=mathieu.poirier@linaro.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).