From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] expr: do not suppress OP_EQ when RHS is bitmask type
Date: Fri, 4 Apr 2014 17:23:44 +0200 [thread overview]
Message-ID: <20140404152307.GA3278@localhost> (raw)
In-Reply-To: <20140404142333.GA28798@macbook.localnet>
On Fri, Apr 04, 2014 at 04:24:40PM +0200, Patrick McHardy wrote:
> > > If an equality relation is explicitly specified by the user, it also needs
> > > to be printed. Florian's change is all we need from what I can tell.
> >
> > Then we have to document that in some cases key == value and key
> > value are equivalent, and when it comes to flags it is not, which is
> > still rare to me.
>
> Sure. I think I already have it in my documentation. Its basically simply
> documenting what the implicit op means in which context.
OK, please go ahead push it, thanks.
next prev parent reply other threads:[~2014-04-04 15:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 22:08 [PATCH nft] expr: do not suppress OP_EQ when RHS is bitmask type Florian Westphal
2014-04-04 8:17 ` Pablo Neira Ayuso
2014-04-04 8:33 ` Florian Westphal
2014-04-04 9:44 ` Pablo Neira Ayuso
2014-04-04 12:09 ` Patrick McHardy
2014-04-04 14:04 ` Pablo Neira Ayuso
2014-04-04 14:24 ` Patrick McHardy
2014-04-04 15:23 ` Pablo Neira Ayuso [this message]
2014-04-04 15:39 ` Florian Westphal
2014-04-04 12:07 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140404152307.GA3278@localhost \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).