From: David Miller <davem@davemloft.net>
To: geert@linux-m68k.org
Cc: rdunlap@infradead.org, sfr@canb.auug.org.au,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: linux-next: Tree for Apr 1 (netfilter)
Date: Sun, 06 Apr 2014 11:31:06 -0400 (EDT) [thread overview]
Message-ID: <20140406.113106.564835222660199498.davem@davemloft.net> (raw)
In-Reply-To: <CAMuHMdXaoUvUButpaDYQh6aj=Zm9GCS7MKFA_-h8GOo1RkOObw@mail.gmail.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Sun, 6 Apr 2014 15:50:04 +0200
> On Tue, Apr 1, 2014 at 9:22 PM, David Miller <davem@davemloft.net> wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>> Date: Tue, 01 Apr 2014 11:34:15 -0700
>>
>>> on x86_64:
>>>
>>> net/netfilter/xt_connlimit.c: In function 'connlimit_mt_check':
>>> net/netfilter/xt_connlimit.c:380:18: warning: division by zero [-Wdiv-by-zero]
>>>
>>> Maybe just use CONNLIMIT_LOCK_SLOTS instead of ARRAY_SIZE(...).
>>
>> I'd rather see that ARRAY_SIZE() be adjusted to work cleanly for zero
>> sized array elements.
>
> Anyone with a suggestion?
>
> Please note this is now in Linus' tree, possibly crashing people's boxes...
I took in the version of the fix I didn't like via Pablo for
now.
next prev parent reply other threads:[~2014-04-06 15:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140401183907.a5127cadbe7116261096beaa@canb.auug.org.au>
2014-04-01 18:34 ` linux-next: Tree for Apr 1 (netfilter) Randy Dunlap
2014-04-01 19:22 ` David Miller
2014-04-06 13:50 ` Geert Uytterhoeven
2014-04-06 15:31 ` David Miller [this message]
2014-04-06 16:08 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140406.113106.564835222660199498.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).