[nftables PATCH v2] src: rule: fix crash in set listing

[nftables PATCH v2] src: rule: fix crash in set listing

[Ana Rey]

It fixes an invalid read that is shown by valgrind.

==3962== Invalid read of size 4
==3962==    at 0x407040: do_command (rule.c:692)
==3962==    by 0x40588C: nft_run (main.c:183)
==3962==    by 0x405469: main (main.c:334)
==3962==  Address 0x10 is not stack'd, malloc'd or (recently) free'd

Signed-off-by: Ana Rey <anarey@gmail.com>
---
[Changes in v2]
*  I fix description and subject in this patch.


 src/rule.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/rule.c b/src/rule.c
index 00dedf5..18ae6b1 100644
--- a/src/rule.c
+++ b/src/rule.c
@@ -674,7 +674,7 @@ static int do_command_list(struct netlink_ctx *ctx, struct cmd *cmd)
 				return -1;
 			set_print(set);
 		}
-		break;
+		return 0;
 	case CMD_OBJ_SET:
 		if (netlink_get_set(ctx, &cmd->handle, &cmd->location) < 0)
 			return -1;
-- 
1.9.0

Re: [nftables PATCH v2] src: rule: fix crash in set listing

[Pablo Neira Ayuso]

On Tue, Apr 08, 2014 at 10:19:41AM +0200, Ana Rey wrote:
> It fixes an invalid read that is shown by valgrind.
> 
> ==3962== Invalid read of size 4
> ==3962==    at 0x407040: do_command (rule.c:692)
> ==3962==    by 0x40588C: nft_run (main.c:183)
> ==3962==    by 0x405469: main (main.c:334)
> ==3962==  Address 0x10 is not stack'd, malloc'd or (recently) free'd

Applied, thanks Ana.