From: Ken-ichirou MATSUZAWA <chamaken@gmail.com>
To: netfilter-devel@vger.kernel.org
Subject: [libnetfilter_conntrack/ulogd PATCH 0/3] add mark filter
Date: Tue, 8 Apr 2014 19:26:16 +0900 [thread overview]
Message-ID: <20140408102614.GA29462@gmail.com> (raw)
Hello,
This patch series enables mark filtering in NFCT plugin.
Would you review it? I think there are two issues:
* libnetfilter_conntrack
I reused struct nfct_filter_dump_mark for NFCT_FILTER_MARK
nfct_filter_add_attr(). Should I introduce a new one which
will be the same field?
* ulogd
I've changed all dump function to use nfct_filter_dump
excepting in do_purge(). It may require many tests so that
is it better having a field to check mark filter has set
and checking it on dumping?
Thanks.
next reply other threads:[~2014-04-08 10:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 10:26 Ken-ichirou MATSUZAWA [this message]
2014-04-08 10:30 ` [libnetfilter_conntrack PATCH 1/3] conntrack: add mark event filter Ken-ichirou MATSUZAWA
2014-04-14 12:53 ` Pablo Neira Ayuso
2014-04-15 11:54 ` [libnetfilter_conntrack PATCH 1/3 resend] " Ken-ichirou MATSUZAWA
2014-04-08 10:32 ` [ulogd PATCH 2/3] " Ken-ichirou MATSUZAWA
2014-04-14 12:54 ` Pablo Neira Ayuso
2014-04-08 10:34 ` [ulogd PATCH 3/3] add mark dump filter Ken-ichirou MATSUZAWA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140408102614.GA29462@gmail.com \
--to=chamaken@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).