[nft PATCH] expression: Fix inconsistent output in set

[nft PATCH] expression: Fix inconsistent output in set

[Ana Rey]

Add a whitespace between the last element in a set and the close braces.

Old output set:

	set set-test {
		type ipv4_address
		elements = { 192.168.1.44, 192.168.2.4}
	}

New output set:
	set set-test {
		type ipv4_address
		elements = { 192.168.1.44, 192.168.2.4 }
	}

Signed-off-by: Ana Rey <anarey@gmail.com>
---
 src/expression.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/expression.c b/src/expression.c
index fa14d99..3b299ff 100644
--- a/src/expression.c
+++ b/src/expression.c
@@ -734,7 +734,7 @@ static void set_expr_print(const struct expr *expr)
 {
 	printf("{ ");
 	compound_expr_print(expr, ", ");
-	printf("}");
+	printf(" }");
 }
 
 static void set_expr_set_type(const struct expr *expr,
-- 
1.9.0

Re: [nft PATCH] expression: Fix inconsistent output in set

[Patrick McHardy]

On Fri, Apr 11, 2014 at 10:26:46AM +0200, Ana Rey wrote:
> Add a whitespace between the last element in a set and the close braces.
> 
> Old output set:
> 
> 	set set-test {
> 		type ipv4_address
> 		elements = { 192.168.1.44, 192.168.2.4}
> 	}
> 
> New output set:
> 	set set-test {
> 		type ipv4_address
> 		elements = { 192.168.1.44, 192.168.2.4 }
> 	}
> 

That's actually deliberate. A space is always added before a set member, but never
after.