From: Patrick McHardy <kaber@trash.net>
To: pablo@netfilter.org
Cc: netfilter-devel@vger.kernel.org
Subject: nftables data type names
Date: Sat, 12 Apr 2014 12:29:01 +0200 [thread overview]
Message-ID: <20140412102901.GA8090@macbook.localnet> (raw)
Before the upcoming release, I'd like to add some more consistency among
nftables data type names. We currently have the following types:
ct_state
ct_dir
ct_status
ct_label
invalid
verdict
nfproto
bitmask
integer
string
lladdr
ipv4_address
ipv6_address
inet_protocol
inet_service
mark
time
mh_type
realm
tc_handle
ifindex
arphrd
uid
gid
icmp_type
tcp_flag
dccp_pkttype
icmpv6_type
arp_op
etheraddr
ethertype
In some cases we're more verbose, in other we're using abrevations.
I'd like to decide for either one.
The following ones should IMO definitely be changed:
- etheraddr => ether_address or mac_address. ether_addr would be more
consistent with ethertype.
- ethertype => ether_type if ether_addr is used
- optionally: *_address => *_addr
- otherwise: ll_addr => ll_address
- arphrd => iftype/interface_type?
If we're deciding for more verbose names (which IMO is fine for types),
I'd also change:
- arp_op => arp_operation
- ifindex => interface_index
- nfproto => nf_protocol
otherwise:
- inet_protocol => inet_proto
- *_address -> *_addr
Basically the should be human readable, not programmer readable, should
describe what they actually are (not arphrd) and should be consistent.
Any comments or suggestions?
next reply other threads:[~2014-04-12 10:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-12 10:29 Patrick McHardy [this message]
2014-04-12 10:56 ` nftables data type names Florian Westphal
2014-04-12 11:03 ` Patrick McHardy
2014-04-13 10:57 ` Patrick McHardy
2014-04-13 12:37 ` Pablo Neira Ayuso
2014-04-13 14:21 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140412102901.GA8090@macbook.localnet \
--to=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).