netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Ana Rey <anarey@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [libnftnl PATCH] tests: Fix a memory leak
Date: Mon, 14 Apr 2014 10:49:24 +0200	[thread overview]
Message-ID: <20140414084924.GB6200@localhost> (raw)
In-Reply-To: <77e2db7e796774f9155dcc91531dc8a13bea1a94.1397411811.git.anarey@gmail.com>

On Sun, Apr 13, 2014 at 08:08:34PM +0200, Ana Rey wrote:
> Free nft_parse_err struct when there is an error in execute_test function.
> 
> It solves the following memory leak shown by valgrind.
> 
> ==7845== 24 bytes in 1 blocks are still reachable in loss record 1 of 2
> ==7845==    at 0x4C29590: calloc (vg_replace_malloc.c:618)
> ==7845==    by 0x401740: execute_test_file (nft-parsing-test.c:249)
> ==7845==    by 0x400EBB: main (nft-parsing-test.c:330)

Applied, thanks.

  reply	other threads:[~2014-04-14  8:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-13 18:08 [libnftnl PATCH] target: Fix an invalid read Ana Rey
2014-04-13 18:08 ` [libnftnl PATCH] tests: Fix a memory leak Ana Rey
2014-04-14  8:49   ` Pablo Neira Ayuso [this message]
2014-04-13 18:21 ` [libnftnl PATCH] target: Fix an invalid read Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140414084924.GB6200@localhost \
    --to=pablo@netfilter.org \
    --cc=anarey@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).