From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [nft PATCH 0/8] nft event monitor Date: Mon, 14 Apr 2014 14:32:52 +0200 Message-ID: <20140414123252.GB21947@localhost> References: <20140414101634.5018.86819.stgit@nfdev.cica.es> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org To: Arturo Borrero Gonzalez Return-path: Received: from mail.us.es ([193.147.175.20]:43889 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752211AbaDNMc5 (ORCPT ); Mon, 14 Apr 2014 08:32:57 -0400 Content-Disposition: inline In-Reply-To: <20140414101634.5018.86819.stgit@nfdev.cica.es> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Mon, Apr 14, 2014 at 12:17:03PM +0200, Arturo Borrero Gonzalez wrote: > The following series implements a basic nftables monitor via Netlink messages. Nice series. > Most of the work in first patches is related to refactorization/generalization > of code. > > The final patch is the big one. This time is OK with me, but next time you can probably split it in smaller chunks, so you add table events in one patch, then chain event in another, and so on. So 8/8 gets distributed is several patches. But I think it's also reasonable to have it in one patch for this time. Please wait to see if Patrick and others have comments on it and then go revisit 8/8, thanks Arturo.