netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Ana Rey <anarey@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [libnftnl PATCH] set-elem: fix a memory leak
Date: Wed, 16 Apr 2014 20:09:42 +0200	[thread overview]
Message-ID: <20140416180942.GB5144@localhost> (raw)
In-Reply-To: <8df9d8df7c8a2c0fa13763fcae5e57f04a4d0362.1397556694.git.anarey@gmail.com>

On Tue, Apr 15, 2014 at 12:13:47PM +0200, Ana Rey wrote:
> Valgrind reports the following memory leak:
> 
> valgrind  --leak-check=full ./nft-parsing-test -f jsonfiles/63-set.json
> ==7131== HEAP SUMMARY:
> ==7131==     in use at exit: 2 bytes in 1 blocks
> ==7131==   total heap usage: 155 allocs, 154 frees, 6,497 bytes allocated
> ==7131==
> ==7131== 2 bytes in 1 blocks are definitely lost in loss record 1 of 1
> ==7131==    at 0x4C274A0: malloc (vg_replace_malloc.c:291)
> ==7131==    by 0x590B829: strdup (strdup.c:42)
> ==7131==    by 0x4E4341A: nft_data_reg_json_parse (data_reg.c:55)
> ==7131==    by 0x4E4093A: nft_jansson_data_reg_parse (jansson.c:231)
> ==7131==    by 0x4E40A1B: nft_jansson_et_elem_parse (jansson.c:257)
> ==7131==    by 0x4E3CECA: nft_jansson_parse_set (set.c:398)
> ==7131==    by 0x4E3EC65: nft_ruleset_do_parse (ruleset.c:263)
> ==7131==    by 0x401479: test_json (nft-parsing-test.c:129)
> ==7131==    by 0x4017C2: execute_test_file (nft-parsing-test.c:270)
> ==7131==    by 0x400EBB: main (nft-parsing-test.c:332)

Also applied, thanks Ana.

  reply	other threads:[~2014-04-16 18:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-15 10:13 [libnftnl PATCH] lookup: Fix an invalid read Ana Rey
2014-04-15 10:13 ` [libnftnl PATCH] set-elem: fix a memory leak Ana Rey
2014-04-16 18:09   ` Pablo Neira Ayuso [this message]
2014-04-16 18:09 ` [libnftnl PATCH] lookup: Fix an invalid read Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140416180942.GB5144@localhost \
    --to=pablo@netfilter.org \
    --cc=anarey@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).