From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH lnf-queue] src: PF_BIND/UNBIND is ignored in 3.8 and later
Date: Thu, 24 Apr 2014 12:09:10 +0200 [thread overview]
Message-ID: <20140424100910.GC13717@breakpoint.cc> (raw)
In-Reply-To: <20140424100105.GA8151@localhost>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > - nlh = nfq_hdr_put(buf, NFQNL_MSG_CONFIG, 0);
> > - nfq_nlmsg_cfg_put_cmd(nlh, AF_INET, NFQNL_CFG_CMD_PF_UNBIND);
> > -
> > - if (mnl_socket_sendto(nl, nlh, nlh->nlmsg_len) < 0) {
> > - perror("mnl_socket_send");
> > - exit(EXIT_FAILURE);
> > - }
> > -
> > + /* PF_BIND is not needed with kernels 3.8 and later */
>
> My only concern is that people using old kernels won't manage to run
> this example, I think there are quite a lot of people running < 3.8,
> so we may hit confusion from the other side.
I pushed the patch without the UNBIND removal.
Thanks.
prev parent reply other threads:[~2014-04-24 10:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 9:01 [PATCH lnf-queue] src: PF_BIND/UNBIND is ignored in 3.8 and later Florian Westphal
2014-04-24 10:01 ` Pablo Neira Ayuso
2014-04-24 10:09 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424100910.GC13717@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).