netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [libnftnl PATCH] common: fix unconditional output of event wrapping stuff
@ 2014-04-28 10:58 Arturo Borrero Gonzalez
  2014-04-28 14:25 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 2+ messages in thread
From: Arturo Borrero Gonzalez @ 2014-04-28 10:58 UTC (permalink / raw)
  To: netfilter-devel; +Cc: pablo

We can't unconditionally print out these strings.

Before this patch, objects being printed will be treated as an 'unkown' event.

Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
---
 src/common.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/common.c b/src/common.c
index 929f25d..52e5f0e 100644
--- a/src/common.c
+++ b/src/common.c
@@ -72,6 +72,9 @@ int nft_event_header_snprintf(char *buf, size_t size, uint32_t type,
 {
 	int ret = 0;
 
+	if (!(flags & NFT_OF_EVENT_ANY))
+		return 0;
+
 	switch (type) {
 	case NFT_OUTPUT_XML:
 		if (flags & NFT_OF_EVENT_NEW) {


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [libnftnl PATCH] common: fix unconditional output of event wrapping stuff
  2014-04-28 10:58 [libnftnl PATCH] common: fix unconditional output of event wrapping stuff Arturo Borrero Gonzalez
@ 2014-04-28 14:25 ` Pablo Neira Ayuso
  0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2014-04-28 14:25 UTC (permalink / raw)
  To: Arturo Borrero Gonzalez; +Cc: netfilter-devel

On Mon, Apr 28, 2014 at 12:58:38PM +0200, Arturo Borrero Gonzalez wrote:
> We can't unconditionally print out these strings.
> 
> Before this patch, objects being printed will be treated as an 'unkown' event.

Applied, thanks Arturo.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-04-28 14:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-28 10:58 [libnftnl PATCH] common: fix unconditional output of event wrapping stuff Arturo Borrero Gonzalez
2014-04-28 14:25 ` Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).