* [PATCH] netfilter: Fix potential use after free in ip6_route_me_harder()
@ 2014-05-08 13:22 Sergey Popovich
2014-05-09 10:44 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Sergey Popovich @ 2014-05-08 13:22 UTC (permalink / raw)
To: netfilter-devel
Dst is released one line before we access it again with dst->error.
Fixes: 58e35d147128 netfilter: ipv6: propagate routing errors from
ip6_route_me_harder()
Signed-off-by: Sergey Popovich <popovich_sergei@mail.ru>
---
net/ipv6/netfilter.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/net/ipv6/netfilter.c b/net/ipv6/netfilter.c
index 95f3f1d..d38e6a8 100644
--- a/net/ipv6/netfilter.c
+++ b/net/ipv6/netfilter.c
@@ -30,13 +30,15 @@ int ip6_route_me_harder(struct sk_buff *skb)
.daddr = iph->daddr,
.saddr = iph->saddr,
};
+ int err;
dst = ip6_route_output(net, skb->sk, &fl6);
- if (dst->error) {
+ err = dst->error;
+ if (err) {
IP6_INC_STATS(net, ip6_dst_idev(dst), IPSTATS_MIB_OUTNOROUTES);
LIMIT_NETDEBUG(KERN_DEBUG "ip6_route_me_harder: No more route.\n");
dst_release(dst);
- return dst->error;
+ return err;
}
/* Drop old route. */
--
1.8.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] netfilter: Fix potential use after free in ip6_route_me_harder()
2014-05-08 13:22 [PATCH] netfilter: Fix potential use after free in ip6_route_me_harder() Sergey Popovich
@ 2014-05-09 10:44 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2014-05-09 10:44 UTC (permalink / raw)
To: Sergey Popovich; +Cc: netfilter-devel
On Thu, May 08, 2014 at 04:22:35PM +0300, Sergey Popovich wrote:
> Dst is released one line before we access it again with dst->error.
>
> Fixes: 58e35d147128 netfilter: ipv6: propagate routing errors from
> ip6_route_me_harder()
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-09 10:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-08 13:22 [PATCH] netfilter: Fix potential use after free in ip6_route_me_harder() Sergey Popovich
2014-05-09 10:44 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).