Re: [contrack-tools PATCH] build: do not compile nfct if we disabled cttimeout

[Hangbin Liu <liuhangbin@gmail.com>]

On Fri, May 09, 2014 at 01:29:59PM +0200, Pablo Neira Ayuso wrote:
> On Thu, May 08, 2014 at 06:02:25PM +0800, Hangbin Liu wrote:
> > If we do not have libnetfilter_cttimeout and disabled cttimeout, conntrack-tools
> > will compile fail because nfct.c include nfnetlink_cttimeout.h. Fix it by only
> > compile nfct when we have enabled cttimeout
> 
> Strange. The nfnetlink_cttimeout.h file is cached inside the
> conntrack-tools tree:
> 
> conntrack-tools/include/linux/netfilter/nfnetlink_cttimeout.h
> 
> Here this compiles fine with my current tree and using:
> 
> ./configure --prefix=/usr --disable-cthelper --disable-cttimeout
> 
> Please, investigate this issue a bit further.

That's weird, on my system without libnetfilter_cttimeout.
# ./configure --prefix=/usr
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes

<snip>

checking for LIBNETFILTER_CONNTRACK... yes
checking for LIBNETFILTER_CTTIMEOUT... no
configure: error: Package requirements (libnetfilter_cttimeout >= 1.0.0) were not met:

No package 'libnetfilter_cttimeout' found

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

Alternatively, you may set the environment variables LIBNETFILTER_CTTIMEOUT_CFLAGS
and LIBNETFILTER_CTTIMEOUT_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.

# ./configure --prefix=/usr --disable-cthelper --disable-cttimeout

<snip>

config.status: executing depfiles commands
config.status: executing libtool commands

conntrack-tools configuration:
  userspace conntrack helper support:   no
  conntrack timeout support:            no

# make
Making all in extensions
make[1]: Entering directory `/root/conntrack-tools/extensions'
  CC       libct_proto_tcp.lo
  CCLD     libct_proto_tcp.la

<snip>

  YACC     read_config_yy.c
updating read_config_yy.h
  CC       read_config_yy.o
  LEX      read_config_lex.c
  CC       read_config_lex.o
read_config_lex.c: In function ‘yylex’:
read_config_lex.c:2333:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
    for ( yyl = 0; yyl < yyleng; ++yyl )
                       ^
read_config_lex.c: In function ‘yy_scan_bytes’:
read_config_lex.c:3658:17: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
  for ( i = 0; i < _yybytes_len; ++i )
                 ^
  CC       stack.o
  CCLD     conntrackd
  CC       nfct.o
nfct.c:26:59: fatal error: libnetfilter_cttimeout/libnetfilter_cttimeout.h: No such file or directory
 #include <libnetfilter_cttimeout/libnetfilter_cttimeout.h>
                                                           ^
compilation terminated.
make[2]: *** [nfct.o] Error 1
make[2]: Leaving directory `/root/conntrack-tools/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/root/conntrack-tools/src'
make: *** [all-recursive] Error 1

It didn't check our library path, should we add it in LIBRARY_PATH?
-- 

Thanks & Best Regards
Hangbin Liu <liuhangbin@gmail.com>