From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [libnftnl PATCH v2] internal: fix SNPRINTF_BUFFER_SIZE macro
Date: Tue, 13 May 2014 17:24:29 +0200 [thread overview]
Message-ID: <20140513152429.GA6907@localhost> (raw)
In-Reply-To: <20140513070735.16866.22056.stgit@nfdev.cica.es>
On Tue, May 13, 2014 at 09:08:15AM +0200, Arturo Borrero Gonzalez wrote:
> We need to store in 'offset' the complete amount of characters as returned
> from _snprintf. The value means how many characters long needs the buffer to be
> in order to store the corresponding string expansion.
>
> Before this patch, in cases where the buffer is smaller than the
> expansion, then ret > len, and therefore ret = len.
> So when incrementing offset, we do it with a wrong value.
>
> All previous versions of libnftnl are unable to handle this situations: small
> buffers (or long string expansion).
>
> BTW, if a caller must reallocate a buffer to the returned value of snprintf, it
> should be ret + 1.
>
> While at it, let's add a check to know if the last snprintf call failed.
Also applied, thanks.
prev parent reply other threads:[~2014-05-13 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 7:08 [libnftnl PATCH v2] internal: fix SNPRINTF_BUFFER_SIZE macro Arturo Borrero Gonzalez
2014-05-13 15:24 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140513152429.GA6907@localhost \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).