From: Florian Westphal <fw@strlen.de>
To: "Álvaro Neira Ayuso" <alvaroneay@gmail.com>
Cc: Patrick McHardy <kaber@trash.net>, netfilter-devel@vger.kernel.org
Subject: Re: [nftables PATCH v2] src: Replace TOS support for using DSCP support
Date: Mon, 2 Jun 2014 10:58:26 +0200 [thread overview]
Message-ID: <20140602085826.GA17858@breakpoint.cc> (raw)
In-Reply-To: <538C307C.30405@gmail.com>
Álvaro Neira Ayuso <alvaroneay@gmail.com> wrote:
> >>Now, when we add a rule with DSCP, in the code generation step, nftables
> >>compares 1 bytes but it should compare 6 bits. I think that the problem should
> >>be in the code generation.
> >
> >I don't really see how this patch changes this. The kernel operates in units
> >of bytes. For anything smaller nftables will have to generate appropriate
> >bitwise operations. Please explain in more detail how this patch changes this.
> >
>
> Now, nothing. For that it's stopped. I'm working for doing a patch
> for operating in the kernel not only with units of bytes like you
> say. In a couple of days, I'm going to send it to the list.
Are you sure this is the right approach?
It might be better to create appropriate masking instructions in
userspace, in most cases byte addressing is sufficient.
Something like this (warning: untested, misses 'reverse' mapping to
remove the implicit bitops when listing rules):
http://git.breakpoint.cc/cgit/fw/nftables.git/commit/?h=payload_offset_04&id=76ac27643400111785a8abb21fdd9e4311d9876e
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-06-02 8:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 10:00 [nftables PATCH 2/2] src: Add DSCP support in nftables Alvaro Neira Ayuso
2014-05-27 14:18 ` [nftables PATCH v2] src: Replace TOS support for using DSCP support Alvaro Neira Ayuso
2014-06-01 20:27 ` Patrick McHardy
2014-06-02 8:06 ` Álvaro Neira Ayuso
2014-06-02 8:58 ` Florian Westphal [this message]
2014-06-02 18:57 ` Álvaro Neira Ayuso
2014-06-03 5:26 ` Maciej Żenczykowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602085826.GA17858@breakpoint.cc \
--to=fw@strlen.de \
--cc=alvaroneay@gmail.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).