From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Ana Rey <anarey@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [libnftnl PATCH v4 3/3] expr: log: Do not print unset values in xml
Date: Thu, 5 Jun 2014 15:18:16 +0200 [thread overview]
Message-ID: <20140605131816.GC20181@localhost> (raw)
In-Reply-To: <1401792116-17742-4-git-send-email-anarey@gmail.com>
On Tue, Jun 03, 2014 at 12:41:56PM +0200, Ana Rey wrote:
> It changes the parse and the snprint functions to omit unset values.
>
> If we used this rule:
> nft add rule ip test output log
>
> We got this xml file:
> <rule><family>ip</family>
> <table>test</table>
> <chain>output</chain>
> <handle>88</handle>
> <expr type="log">
> <prefix>(null)</prefix>
> <group>0</group>
> <snaplen>0</snaplen>
> <qthreshold>0</qthreshold>
> </expr>
> </rule>
>
> And It was imposible import this file.
>
> Now, That rule creates this xml file without null values:
>
> <rule><family>ip</family>
> <table>test</table>
> <chain>output</chain>
> <handle>88</handle>
> <expr type="log">
> </expr>
> </rule>
>
> and It's possible import this xml file.
Applied, thanks Ana.
prev parent reply other threads:[~2014-06-05 13:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 10:41 [libnftnl PATCH v4 0/3] Do not print unset value in xml file Ana Rey
2014-06-03 10:41 ` [libnftnl PATCH v4 1/3] expr: log: Rename variables in nft_rule_expr_log_json_parse functions Ana Rey
2014-06-05 13:17 ` Pablo Neira Ayuso
2014-06-03 10:41 ` [libnftnl PATCH v4 2/3] expr: log: Use nft_rule_expr_set_* in the xml parsing code Ana Rey
2014-06-05 13:17 ` Pablo Neira Ayuso
2014-06-03 10:41 ` [libnftnl PATCH v4 3/3] expr: log: Do not print unset values in xml Ana Rey
2014-06-05 13:18 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140605131816.GC20181@localhost \
--to=pablo@netfilter.org \
--cc=anarey@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).