From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Ana Rey <anarey@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [libnftnl PATCH 3/5] expr: reject: Do not print unset values in xml
Date: Thu, 5 Jun 2014 15:19:49 +0200 [thread overview]
Message-ID: <20140605131949.GF20181@localhost> (raw)
In-Reply-To: <1401881891-4990-4-git-send-email-anarey@gmail.com>
On Wed, Jun 04, 2014 at 01:38:09PM +0200, Ana Rey wrote:
> It changes the parse and the snprint functions to omit unset values.
>
> If we used this rule:
> nft add rule ip test output reject
>
> It gets this xml file:
> [...]
> <expr type="reject">
> <type>0</type>
> <code>0</code>
> </expr>
> </rule></nftables>
>
> Now, That rule creates this xml file without null values:
>
> [...]
> <expr type="reject">
> </expr>
> </rule></nftables>
Applied, thanks.
next prev parent reply other threads:[~2014-06-05 13:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 11:38 [libnftnl PATCH 0/5] reject: Do not print unset value Ana Rey
2014-06-04 11:38 ` [libnftnl PATCH 1/5] expr: reject: Add nft_rule_expr_reject_snprinf_* functions Ana Rey
2014-06-05 13:19 ` Pablo Neira Ayuso
2014-06-04 11:38 ` [libnftnl PATCH 2/5] expr: reject: Use nft_rule_expr_set_* in the xml and default parsing code Ana Rey
2014-06-05 13:19 ` Pablo Neira Ayuso
2014-06-04 11:38 ` [libnftnl PATCH 3/5] expr: reject: Do not print unset values in xml Ana Rey
2014-06-05 13:19 ` Pablo Neira Ayuso [this message]
2014-06-04 11:38 ` [libnftnl PATCH 4/5] expr: reject: Convert the type of a variable Ana Rey
2014-06-05 13:20 ` Pablo Neira Ayuso
2014-06-04 11:38 ` [libnftnl PATCH 5/5] expr: reject: Do not print unset values in json Ana Rey
2014-06-05 13:20 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140605131949.GF20181@localhost \
--to=pablo@netfilter.org \
--cc=anarey@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).