From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Alvaro Neira Ayuso <alvaroneay@gmail.com>
Cc: netfilter-devel@vger.kernel.org, kaber@trash.net
Subject: Re: [nftables PATCH v3] payload: Update the context only in equality relations
Date: Thu, 5 Jun 2014 16:57:08 +0200 [thread overview]
Message-ID: <20140605145708.GA25197@localhost> (raw)
In-Reply-To: <1401720251-9041-1-git-send-email-alvaroneay@gmail.com>
On Mon, Jun 02, 2014 at 04:44:11PM +0200, Alvaro Neira Ayuso wrote:
> If we add this rule:
>
> sudo nft add rule ip test input ip protocol != icmp
>
> and we try to list the rules in the table test, nftables
> show this error:
>
> nft: src/payload.c:76: payload_expr_pctx_update: Assertion `expr->op
> == OP_EQ' failed.
>
> This patch change the function payload_match_postprocess for updating
> only the context in equality relations case.
Applied, thanks.
prev parent reply other threads:[~2014-06-05 14:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 15:04 [nftables PATCH] payload: moderate the expr operation checking Alvaro Neira Ayuso
2014-05-28 9:47 ` [nftables PATCH v2] payload: Relax assert in function payload_expr_pctx_update Alvaro Neira Ayuso
2014-06-01 20:12 ` Patrick McHardy
2014-06-02 14:44 ` [nftables PATCH v3] payload: Update the context only in equality relations Alvaro Neira Ayuso
2014-06-05 14:57 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140605145708.GA25197@localhost \
--to=pablo@netfilter.org \
--cc=alvaroneay@gmail.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).