netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v3] netfilter: conntrack: remove timer from ecache extension
Date: Wed, 11 Jun 2014 10:55:47 +0200	[thread overview]
Message-ID: <20140611085547.GA4131@localhost> (raw)
In-Reply-To: <1402434776-23461-1-git-send-email-fw@strlen.de>

Hi Florian,

Thanks for this new round.

On Tue, Jun 10, 2014 at 11:12:56PM +0200, Florian Westphal wrote:
> This brings the (per-conntrack) ecache extension back to 24 bytes in size
> (was 152 byte on x86_64 with lockdep on).
> 
> When event delivery fails, re-delivery is attempted via work queue.
> 
> Redelivery is attempted at least every 0.1 seconds, but can happen
> more frequently if userspace is not congested.
> 
> The nf_ct_release_dying_list() function is removed.
> With this patch, ownership of the to-be-redelivered conntracks
> (on-dying-list-with-DYING-bit not yet set) is with the work queue,
> which will release the references once event is out.

I think we need to keep the nf_ct_release_dying_list(), otherwise we
will hit problems when destroying the kmem_cache, since the workqueue
may race with that, right?

  reply	other threads:[~2014-06-11  8:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-10 21:12 [PATCH v3] netfilter: conntrack: remove timer from ecache extension Florian Westphal
2014-06-11  8:55 ` Pablo Neira Ayuso [this message]
2014-06-11  9:20   ` Florian Westphal
2014-06-25 17:06     ` Pablo Neira Ayuso
2014-06-25 17:13       ` Florian Westphal
2014-06-25 17:22         ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140611085547.GA4131@localhost \
    --to=pablo@netfilter.org \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).