From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Ana Rey <anarey@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [libnftnl PATCH 3/5] src: set: Do not print unset values in json
Date: Wed, 11 Jun 2014 19:50:26 +0200 [thread overview]
Message-ID: <20140611175026.GB17843@localhost> (raw)
In-Reply-To: <1402501851-22208-5-git-send-email-anarey@gmail.com>
On Wed, Jun 11, 2014 at 05:50:49PM +0200, Ana Rey wrote:
> It changes the parse and the snprint functions to omit unset values.
>
> This json file is gotten for a set:
> {
> "set": {
> "name": "mi6set3",
> "table": "test6",
> "flags": "0",
> "family": "unknown",
> "key_type": "0",
> "key_len": "0",
> "set_elem": [
> {
> "flags": "0",
> "key": {
> "data_reg": {
> "type": "value",
> "len": "16",
> "data0": "0x000080fe",
> "data1": "0x00000000",
> "data2": "0xffb30202",
> "data3": "0x89001efe"
>
> Now, This json file is gotten for a set without unset elements.
> {
> "set": {
> "name": "mi6set3",
> "table": "test6",
> "family": "unknown",
> "set_elem": [
> {
> "key": {
> "data_reg": {
> "type": "value",
> "len": "16",
> "data0": "0x000080fe",
> "data1": "0x00000000",
> "data2": "0xffb30202",
> "data3": "0x89001efe"
I have included a note that says that this is the output when printing
set elements (where the key and key length are not available).
Applied, thanks.
next prev parent reply other threads:[~2014-06-11 17:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 15:50 [libnftnl PATCH 0/5] Set: Do not print unset value Ana Rey
2014-06-11 15:50 ` [libnftnl PATCH 1/5] src: set: Use nft_rule_expr_set_* in the xml parsing code Ana Rey
2014-06-11 17:47 ` Pablo Neira Ayuso
2014-06-11 15:50 ` [libnftnl PATCH] tests: Use the system errors in test_xml Ana Rey
2014-06-11 17:48 ` Pablo Neira Ayuso
2014-06-11 15:50 ` [libnftnl PATCH 2/5] src: set: Do not print unset values in xml Ana Rey
2014-06-11 16:14 ` Arturo Borrero Gonzalez
2014-06-11 17:49 ` Pablo Neira Ayuso
2014-06-11 15:50 ` [libnftnl PATCH 3/5] src: set: Do not print unset values in json Ana Rey
2014-06-11 17:50 ` Pablo Neira Ayuso [this message]
2014-06-11 15:50 ` [libnftnl PATCH 4/5] src: set: Free memory in the same function that is reserved Ana Rey
2014-06-11 17:50 ` Pablo Neira Ayuso
2014-06-11 15:50 ` [libnftnl PATCH 5/5] tests: xmlfile: Test files without unset child elements in set elements Ana Rey
2014-06-11 17:51 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140611175026.GB17843@localhost \
--to=pablo@netfilter.org \
--cc=anarey@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).