From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Domen Puncer <domen.puncer@samsung.com>
Cc: "netfilter-devel@vger.kernel.org" <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH iptables] libxtables: fix getaddrinfo return value usage
Date: Wed, 11 Jun 2014 19:55:50 +0200 [thread overview]
Message-ID: <20140611175550.GA17981@localhost> (raw)
In-Reply-To: <539825E3.6020000@samsung.com>
On Wed, Jun 11, 2014 at 10:48:19AM +0100, Domen Puncer wrote:
> On 11/06/14 10:37, Pablo Neira Ayuso wrote:
> > On Tue, Jun 10, 2014 at 02:29:49PM +0100, Domen Puncer wrote:
> >> getaddrinfo return value on error can also be positive.
> >
> > At quick glance, all EAI_* that I see are negative.
>
> You don't see all of them :-)
> On Android they're positive, e.g.:
> android-ndk-r9d/platforms/android-19/arch-arm/usr/include/netdb.h
> 147 #define EAI_NONAME 8 /* hostname nor servname provided,
> or not known */
I suspected something like this..
Please, next time include this in the patch description since the
beginning, thanks.
> And as a plus, it's not bad to conform to specs.
It sounds like a reasonable assumption to me.
Do you have more patches like this in your queue?
next prev parent reply other threads:[~2014-06-11 17:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-10 13:29 [PATCH iptables] libxtables: fix getaddrinfo return value usage Domen Puncer
2014-06-11 9:37 ` Pablo Neira Ayuso
2014-06-11 9:48 ` Domen Puncer
2014-06-11 17:55 ` Pablo Neira Ayuso [this message]
2014-06-12 7:01 ` Domen Puncer
2014-06-16 9:48 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140611175550.GA17981@localhost \
--to=pablo@netfilter.org \
--cc=domen.puncer@samsung.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).