From: Ken-ichirou MATSUZAWA <chamaken@gmail.com>
To: The netfilter developer mailinglist <netfilter-devel@vger.kernel.org>
Cc: Florian Westphal <fw@strlen.de>
Subject: [PATCH libnetfilter_conntrack] conntrack: remove duplicate code
Date: Tue, 17 Jun 2014 21:12:19 +0900 [thread overview]
Message-ID: <20140617121219.GB24712@gmail.com> (raw)
nfct_filter_dump_set_attr() will set the bit.
Signed-off-by: Ken-ichirou MATSUZAWA <chamas@h4.dion.ne.jp>
---
src/conntrack/filter_dump.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/conntrack/filter_dump.c b/src/conntrack/filter_dump.c
index 9e2e169..4819759 100644
--- a/src/conntrack/filter_dump.c
+++ b/src/conntrack/filter_dump.c
@@ -17,7 +17,6 @@ set_filter_dump_attr_mark(struct nfct_filter_dump *filter_dump,
filter_dump->mark.val = this->val;
filter_dump->mark.mask = this->mask;
- filter_dump->set |= (1 << NFCT_FILTER_DUMP_MARK);
}
static void
@@ -25,7 +24,6 @@ set_filter_dump_attr_family(struct nfct_filter_dump *filter_dump,
const void *value)
{
filter_dump->l3num = *((u_int8_t *)value);
- filter_dump->set |= (1 << NFCT_FILTER_DUMP_L3NUM);
}
const set_filter_dump_attr set_filter_dump_attr_array[NFCT_FILTER_DUMP_MAX] = {
--
1.9.1
reply other threads:[~2014-06-17 12:12 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140617121219.GB24712@gmail.com \
--to=chamaken@gmail.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).