netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v3] netfilter: conntrack: remove timer from ecache extension
Date: Wed, 25 Jun 2014 19:13:27 +0200	[thread overview]
Message-ID: <20140625171327.GE6328@breakpoint.cc> (raw)
In-Reply-To: <20140625170636.GA16571@localhost>

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> This patch looks good to me. I made some experiments again in my
> testbed. I see no packet drops and the result of 'conntrack -L dying |
> wc -l' per second shows small peaks of entries waiting in the dying
> list to be delivered which is followed by empty lists by conntrackd at
> some point.

Thanks a lot for all the testing Pablo.

> However, perhaps the per-second watch is not enough to get
> a real evolution on how the dying list population evolves along time.

Yes, you might be right.
IFF you think its useful, we could add a counter to keep track of the
maximum length of entries that the ecache worker has seen and
export that via ctnetlink (like we do for number of conntracks, search
list restarts, etc etc).

> Anyway, I think this is good enough to get rid of the extra timer. We
> can enqueue this patch to 3.17, unless you have any objection.

No objections from me, thanks Pablo!

  reply	other threads:[~2014-06-25 17:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-10 21:12 [PATCH v3] netfilter: conntrack: remove timer from ecache extension Florian Westphal
2014-06-11  8:55 ` Pablo Neira Ayuso
2014-06-11  9:20   ` Florian Westphal
2014-06-25 17:06     ` Pablo Neira Ayuso
2014-06-25 17:13       ` Florian Westphal [this message]
2014-06-25 17:22         ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140625171327.GE6328@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).