From: Pablo Neira Ayuso <pablo@netfilter.org>
To: lantw44@gmail.com
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/3] extra: use inet_ntop instead of inet_ntoa
Date: Mon, 30 Jun 2014 11:48:48 +0200 [thread overview]
Message-ID: <20140630094848.GA5038@localhost> (raw)
In-Reply-To: <1403260021-8732-1-git-send-email-lantw44@gmail.com>
On Fri, Jun 20, 2014 at 06:26:59PM +0800, lantw44@gmail.com wrote:
> From: Ting-Wei Lan <lantw44@gmail.com>
>
> The result of inet_ntoa() will be overwritten by the next call to
> inet_ntoa(), so using it twice in the same snprintf() call causes
> wrong result.
Applied, thanks Lan.
prev parent reply other threads:[~2014-06-30 9:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 10:26 [PATCH 1/3] extra: use inet_ntop instead of inet_ntoa lantw44
2014-06-20 10:27 ` [PATCH 2/3] extra: fix wrong implementation in nfq_udp_get_payload lantw44
2014-06-30 10:02 ` Pablo Neira Ayuso
2014-06-30 17:00 ` 藍挺瑋
2014-06-20 10:27 ` [PATCH 3/3] extra: fix wrong implementation in nfq_udp_get_payload_len lantw44
2014-06-30 10:11 ` Pablo Neira Ayuso
2014-06-30 9:48 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140630094848.GA5038@localhost \
--to=pablo@netfilter.org \
--cc=lantw44@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox