From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: Re: [PATCH 4/7] autotools conversion: include the header 'config.h' in every C source file. Date: Thu, 10 Jul 2014 14:52:46 +0200 Message-ID: <20140710125245.GA10007@macbook.localnet> References: <1421640070.472816.1404988338916.JavaMail.ngmail@webmail23.arcor-online.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org To: giorgio.nicole@arcor.de Return-path: Received: from stinky.trash.net ([213.144.137.162]:44625 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753333AbaGJMwt (ORCPT ); Thu, 10 Jul 2014 08:52:49 -0400 Content-Disposition: inline In-Reply-To: <1421640070.472816.1404988338916.JavaMail.ngmail@webmail23.arcor-online.net> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Thu, Jul 10, 2014 at 12:32:18PM +0200, giorgio.nicole@arcor.de wrote: > > > > ----- Original Nachricht ---- > Von: Patrick McHardy > An: Giorgio Dal Molin > Datum: 10.07.2014 12:04 > Betreff: Re: [PATCH 4/7] autotools conversion: include the header 'config.h' > in every C source file. > > > On Mon, Jul 07, 2014 at 04:19:28PM +0200, Giorgio Dal Molin wrote: > > > Added an #include to all the C source files so that the > > results > > > of the tests in the configure script are available to all the compilation > > > units. > > > > > > We could have added the include also to 'yacc_parser.y' and 'scanner.l' > > > but we don't, because it is not strictly needed and to avoid to define > > > the variable 'VERSION' two times. > > > > > --- a/src/cli.c > > > +++ b/src/cli.c > > > @@ -11,6 +11,9 @@ > > > * > > > * Development of this code funded by Astaro AG (http://www.astaro.com/) > > > */ > > > +#ifdef HAVE_CONFIG_H > > > +#include > > > +#endif > > > > Do we really need those ifdefs? > > > > Hi, > > do you mean just the #ifdefs or the whole #include ? > > The config.h should be included, unless there are real problems with it; one I've found > is the preprocessor variable VERSION defined in the yacc source 'src/yacc_parser.y': > it would conflict with the same variable defined in the 'config.h'. > > Actually, if you just build the package under linux, using the ./configure... && make all install > you will always generate / include the config.h, so the #ifdef is not strictly needed. So let's remove them. Also I think a lot of programs are using CFLAGS to -include config.h, that might be easier. Please change this one way or the other and address Pablo's comment and I'll merge this.