From: Dan Carpenter <dan.carpenter@oracle.com>
To: Julian Anastasov <ja@ssi.bg>
Cc: Andrey Utkin <andrey.krieger.utkin@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org, coreteam@netfilter.org,
netfilter-devel@vger.kernel.org, lvs-devel@vger.kernel.org,
netdev@vger.kernel.org, dcb314@hotmail.com,
David Miller <davem@davemloft.net>,
kadlec@blackhole.kfki.hu, Patrick McHardy <kaber@trash.net>,
pablo@netfilter.org, Simon Horman <horms@verge.net.au>,
wensong@linux-vs.org
Subject: Re: [PATCH 3/5] net/netfilter/ipvs/ip_vs_ctl.c: drop argument range check just before the check for equality
Date: Tue, 22 Jul 2014 12:14:41 +0300 [thread overview]
Message-ID: <20140722091441.GN18338@mwanda> (raw)
In-Reply-To: <alpine.LFD.2.11.1407221136420.1949@ja.home.ssi.bg>
On Tue, Jul 22, 2014 at 11:52:02AM +0300, Julian Anastasov wrote:
> > > - if (copylen > 128)
> > > + if (*len < (int) copylen || *len < 0) {
> > > + pr_err("get_ctl: len %d < %u\n", *len, copylen);
> >
> > Don't let users flood dmesg. Just return an error. (This can be
> > triggered by non-root as well).
>
> For now both set and get are privileged operations,
> so we can keep it, it can catch if something wrong happens
> with the structure sizes.
If you have namespaces enabled then it's not *that* privaleged.
regards,
dan carpenter
prev parent reply other threads:[~2014-07-22 9:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 15:33 [PATCH 3/5] net/netfilter/ipvs/ip_vs_ctl.c: drop argument range check just before the check for equality Andrey Utkin
2014-07-18 20:48 ` Julian Anastasov
2014-07-18 21:06 ` Andrey Utkin
2014-07-19 22:59 ` Andrey Utkin
2014-07-19 23:03 ` Andrey Utkin
2014-07-21 20:01 ` Julian Anastasov
2014-07-22 7:42 ` Dan Carpenter
2014-07-22 8:52 ` Julian Anastasov
2014-07-22 9:14 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140722091441.GN18338@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andrey.krieger.utkin@gmail.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=dcb314@hotmail.com \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).