From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Patrick McHardy <kaber@trash.net>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org
Subject: Re: netfilter: remnants of ulog targets
Date: Wed, 23 Jul 2014 11:39:49 +0200 [thread overview]
Message-ID: <20140723093949.GA3754@salvia> (raw)
In-Reply-To: <1406107694.12441.8.camel@x220>
On Wed, Jul 23, 2014 at 11:28:14AM +0200, Paul Bolle wrote:
> Pablo,
>
> Your commit 7200135bc1e6 ("netfilter: kill ulog targets") landed in
> today's linux-next (ie, next-20140723). It removes two Kconfig symbols:
> IP_NF_TARGET_ULOG and BRIDGE_EBT_ULOG.
>
> It left a few references to the related macros untouched:
> $ git grep -n -e IP_NF_TARGET_ULOG -e BRIDGE_EBT_ULOG next-20140723 | grep -v defconf
> next-20140723:include/net/netns/x_tables.h:18:#if IS_ENABLED(CONFIG_IP_NF_TARGET_ULOG)
> next-20140723:include/net/netns/x_tables.h:21:#if IS_ENABLED(CONFIG_BRIDGE_EBT_ULOG)
> next-20140723:net/bridge/netfilter/Makefile:39:obj-$(CONFIG_BRIDGE_EBT_ULOG) += ebt_ulog.o
> next-20140723:net/ipv4/netfilter/Makefile:60:obj-$(CONFIG_IP_NF_TARGET_ULOG) += ipt_ULOG.o
>
> Is the trivial patch to clean up these remnants of the ulog targets
> queued somewhere? If not, should I submit it?
Yes, you can send me a patch to kill that dead code. Thanks.
next prev parent reply other threads:[~2014-07-23 9:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 9:28 netfilter: remnants of ulog targets Paul Bolle
2014-07-23 9:39 ` Pablo Neira Ayuso [this message]
2014-07-25 12:25 ` [PATCH] [linux-next] netfilter: kill " Paul Bolle
2014-07-25 13:01 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140723093949.GA3754@salvia \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).