* [PATCH] netfilter: nf_conntrack: remove exceptional & on function name
@ 2014-07-24 20:17 Himangi Saraogi
2014-07-25 13:00 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Himangi Saraogi @ 2014-07-24 20:17 UTC (permalink / raw)
To: Pablo Neira Ayuso, Patrick McHardy, Jozsef Kadlecsik,
David S. Miller, Alexey Kuznetsov, James Morris,
Hideaki YOSHIFUJI, netfilter-devel, coreteam, netdev,
linux-kernel
Cc: Julia Lawall
In this file, function names are otherwise used as pointers without &.
A simplified version of the Coccinelle semantic patch that makes this
change is as follows:
// <smpl>
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
// </smpl>
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
---
net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c b/net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c
index 8127dc8..41744cd 100644
--- a/net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c
+++ b/net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c
@@ -358,7 +358,7 @@ static struct nf_sockopt_ops so_getorigdst = {
.pf = PF_INET,
.get_optmin = SO_ORIGINAL_DST,
.get_optmax = SO_ORIGINAL_DST+1,
- .get = &getorigdst,
+ .get = getorigdst,
.owner = THIS_MODULE,
};
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] netfilter: nf_conntrack: remove exceptional & on function name
2014-07-24 20:17 [PATCH] netfilter: nf_conntrack: remove exceptional & on function name Himangi Saraogi
@ 2014-07-25 13:00 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2014-07-25 13:00 UTC (permalink / raw)
To: Himangi Saraogi
Cc: Patrick McHardy, Jozsef Kadlecsik, David S. Miller,
Alexey Kuznetsov, James Morris, Hideaki YOSHIFUJI,
netfilter-devel, coreteam, netdev, linux-kernel, Julia Lawall
On Fri, Jul 25, 2014 at 01:47:16AM +0530, Himangi Saraogi wrote:
> In this file, function names are otherwise used as pointers without &.
>
> A simplified version of the Coccinelle semantic patch that makes this
> change is as follows:
>
> // <smpl>
> @r@
> identifier f;
> @@
>
> f(...) { ... }
>
> @@
> identifier r.f;
> @@
>
> - &f
> + f
> // </smpl>
Applied, thanks Himangi.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-25 13:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-24 20:17 [PATCH] netfilter: nf_conntrack: remove exceptional & on function name Himangi Saraogi
2014-07-25 13:00 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).