From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jiri Prchal <jiri.prchal@aksignal.cz>
Cc: linux-leds@vger.kernel.org, rpurdie@rpsys.net, kaber@trash.net,
kadlec@blackhole.kfki.hu, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, cooloney@gmail.com
Subject: Re: [PATCH resend] nf: xt_LED: fix too short led-always-blink
Date: Fri, 25 Jul 2014 16:11:23 +0200 [thread overview]
Message-ID: <20140725141123.GA17926@salvia> (raw)
In-Reply-To: <945bac3162d5842491848f3d3ab43ba4c5fac157.1406291927.git.jiri.prchal@aksignal.cz>
On Fri, Jul 25, 2014 at 03:58:33PM +0200, Jiri Prchal wrote:
> From: Jiri <jiri.prchal@aksignal.cz>
>
> If led-always-blink is set, then between switch led OFF and ON
> is almost zero time. So blink is invisible. This use oneshot led trigger
> with fixed time 50ms witch is enough to see blink.
Applied, thanks.
> diff --git a/net/netfilter/xt_LED.c b/net/netfilter/xt_LED.c
> index 993de2b..9c12f16 100644
> --- a/net/netfilter/xt_LED.c
> +++ b/net/netfilter/xt_LED.c
> @@ -28,6 +28,8 @@
>
> #include <linux/netfilter/xt_LED.h>
>
> +#define XT_LED_BLINK_DELAY 50 /* ms */
BTW, I moved this definition closer to scope where it is used, just for
readability reasons.
prev parent reply other threads:[~2014-07-25 14:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 13:58 [PATCH resend] nf: xt_LED: fix too short led-always-blink Jiri Prchal
2014-07-25 14:11 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140725141123.GA17926@salvia \
--to=pablo@netfilter.org \
--cc=cooloney@gmail.com \
--cc=coreteam@netfilter.org \
--cc=jiri.prchal@aksignal.cz \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-leds@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).