From: David Miller <davem@davemloft.net>
To: fw@strlen.de
Cc: pablo@netfilter.org, therbert@google.com,
netfilter-devel@vger.kernel.org, davej@redhat.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: reallocate new socket option number for IPV6_AUTOFLOWLABEL
Date: Wed, 06 Aug 2014 15:17:15 -0700 (PDT) [thread overview]
Message-ID: <20140806.151715.2113268376810129182.davem@davemloft.net> (raw)
In-Reply-To: <20140806221313.GA4426@breakpoint.cc>
From: Florian Westphal <fw@strlen.de>
Date: Thu, 7 Aug 2014 00:13:13 +0200
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
>> cb1ce2e ("ipv6: Implement automatic flow label generation on transmit")
>> accidentally uses socket option 64, which is already used by ip6tables:
>>
>> IP6T_SO_SET_REPLACE / IP6T_SO_GET_INFO 64
>> IP6T_SO_SET_ADD_COUNTERS / IP6T_SO_GET_ENTRIES 65
>>
>> There is comment include/uapi/linux/in6.h warning about that.
>>
>> Cc: Tom Herbert <therbert@google.com>
>> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
...
>> @@ -250,6 +249,7 @@ struct in6_flowlabel_req {
>> */
>> #define IPV6_RECVTCLASS 66
>> #define IPV6_TCLASS 67
>> +#define IPV6_AUTOFLOWLABEL 68
>
> This clashes with IP6T_SO_GET_REVISION_MATCH 8-}
:-) 77 appears to be the next actually usable value.
next prev parent reply other threads:[~2014-08-06 22:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 22:10 [PATCH] net: reallocate new socket option number for IPV6_AUTOFLOWLABEL Pablo Neira Ayuso
2014-08-06 22:13 ` Florian Westphal
2014-08-06 22:17 ` David Miller [this message]
2014-08-06 22:15 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140806.151715.2113268376810129182.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=davej@redhat.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).