From: Dave Jones <davej@redhat.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: therbert@google.com, netfilter-devel@vger.kernel.org,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: reallocate new socket option number for IPV6_AUTOFLOWLABEL
Date: Wed, 6 Aug 2014 19:00:22 -0400 [thread overview]
Message-ID: <20140806230022.GA23144@redhat.com> (raw)
In-Reply-To: <1407363429-3870-1-git-send-email-pablo@netfilter.org>
On Thu, Aug 07, 2014 at 12:17:09AM +0200, Pablo Neira Ayuso wrote:
> cb1ce2e ("ipv6: Implement automatic flow label generation on transmit")
> accidentally uses socket option 64, which is already used by ip6tables:
>
> IP6T_SO_SET_REPLACE / IP6T_SO_GET_INFO 64
> IP6T_SO_SET_ADD_COUNTERS / IP6T_SO_GET_ENTRIES 65
>
> There is comment include/uapi/linux/in6.h warning about that.
>
> Allocate 70 for this, which seems to be unused instead.
>
> Cc: Tom Herbert <therbert@google.com>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Just tested this, ip6tables works fine now.
thanks Pablo.
Dave
prev parent reply other threads:[~2014-08-06 23:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 22:17 [PATCH v2] net: reallocate new socket option number for IPV6_AUTOFLOWLABEL Pablo Neira Ayuso
2014-08-06 22:25 ` David Miller
2014-08-06 23:00 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140806230022.GA23144@redhat.com \
--to=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).