From: Holger Eitzenberger <holger@eitzenberger.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: Josh Hunt <johunt@akamai.com>, Patrick McHardy <kaber@trash.net>,
Florian Westphal <fw@strlen.de>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"netfilter-devel@vger.kernel.org"
<netfilter-devel@vger.kernel.org>,
"coreteam@netfilter.org" <coreteam@netfilter.org>,
Harald Welte <laforge@netfilter.org>
Subject: Re: [PATCH] netfilter: xt_hashlimit: handle iptables-restore of hash with same name
Date: Fri, 15 Aug 2014 09:24:43 +0200 [thread overview]
Message-ID: <20140815072443.GT3549@imap.eitzenberger.org> (raw)
In-Reply-To: <alpine.LSU.2.11.1408150545340.8983@nerf08.vanv.qr>
> >For case 2) the behaviour is unexpected: when using iptables-restore
> >to update an already existing hashtable <NAME> the updates are
> >ignored.
>
> Well, in a way, this is expected. If ruletable A references hashtable
> G and you restore ruletable B also referencing G, you don't
> necessarily want to clear out G.
I agree when having multiple rules accessing same hashtable. But on
rule update it is a bug.
I am fine maintaining the patch adressing the rule update, as I am
aware of the change in behaviour for the other case.
/Holger
prev parent reply other threads:[~2014-08-15 7:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 4:54 [PATCH] netfilter: xt_hashlimit: handle iptables-restore of hash with same name Josh Hunt
2014-07-22 20:49 ` Josh Hunt
2014-07-24 8:49 ` Florian Westphal
2014-07-24 10:53 ` Patrick McHardy
2014-07-24 11:48 ` Florian Westphal
2014-07-25 16:57 ` Josh Hunt
2014-08-14 14:09 ` Holger Eitzenberger
2014-08-15 3:58 ` Jan Engelhardt
2014-08-15 7:24 ` Holger Eitzenberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140815072443.GT3549@imap.eitzenberger.org \
--to=holger@eitzenberger.org \
--cc=coreteam@netfilter.org \
--cc=fw@strlen.de \
--cc=jengelh@inai.de \
--cc=johunt@akamai.com \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=laforge@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).