netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [nft PATCH] linealize: generate unary expression with the appropiate operation
@ 2014-08-18 21:00 Alvaro Neira Ayuso
  2014-08-18 22:09 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 2+ messages in thread
From: Alvaro Neira Ayuso @ 2014-08-18 21:00 UTC (permalink / raw)
  To: netfilter-devel

If we add a unary expression which the operation is ntoh, we use hton.
This looks like a typo.

Signed-off-by: Alvaro Neira Ayuso <alvaroneay@gmail.com>
---
 src/netlink_linearize.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/netlink_linearize.c b/src/netlink_linearize.c
index 0e1d87c..3e48e9b 100644
--- a/src/netlink_linearize.c
+++ b/src/netlink_linearize.c
@@ -442,7 +442,7 @@ static enum nft_byteorder_ops netlink_gen_unary_op(enum ops op)
 	case OP_HTON:
 		return NFT_BYTEORDER_HTON;
 	case OP_NTOH:
-		return NFT_BYTEORDER_HTON;
+		return NFT_BYTEORDER_NTOH;
 	default:
 		BUG("invalid unary operation %u\n", op);
 	}
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [nft PATCH] linealize: generate unary expression with the appropiate operation
  2014-08-18 21:00 [nft PATCH] linealize: generate unary expression with the appropiate operation Alvaro Neira Ayuso
@ 2014-08-18 22:09 ` Pablo Neira Ayuso
  0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2014-08-18 22:09 UTC (permalink / raw)
  To: Alvaro Neira Ayuso; +Cc: netfilter-devel


On Mon, Aug 18, 2014 at 11:00:12PM +0200, Alvaro Neira Ayuso wrote:
> If we add a unary expression which the operation is ntoh, we use hton.
> This looks like a typo.

Applied, thanks.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-08-18 22:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-18 21:00 [nft PATCH] linealize: generate unary expression with the appropiate operation Alvaro Neira Ayuso
2014-08-18 22:09 ` Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).