* [PATCH] netfilter: x_tables: allow to use default cgroup match
@ 2014-08-18 13:46 Daniel Borkmann
2014-08-19 11:26 ` Alexey Perevalov
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Borkmann @ 2014-08-18 13:46 UTC (permalink / raw)
To: pablo; +Cc: a.perevalov, netfilter-devel
There's actually no good reason why we cannot use cgroup id 0,
so lets just remove this artificial barrier.
Reported-by: Alexey Perevalov <a.perevalov@samsung.com>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
---
net/netfilter/xt_cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/xt_cgroup.c b/net/netfilter/xt_cgroup.c
index f4e8330..7198d66 100644
--- a/net/netfilter/xt_cgroup.c
+++ b/net/netfilter/xt_cgroup.c
@@ -31,7 +31,7 @@ static int cgroup_mt_check(const struct xt_mtchk_param *par)
if (info->invert & ~1)
return -EINVAL;
- return info->id ? 0 : -EINVAL;
+ return 0;
}
static bool
--
1.7.11.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] netfilter: x_tables: allow to use default cgroup match
2014-08-18 13:46 [PATCH] netfilter: x_tables: allow to use default cgroup match Daniel Borkmann
@ 2014-08-19 11:26 ` Alexey Perevalov
2014-08-19 19:39 ` Pablo Neira Ayuso
0 siblings, 1 reply; 3+ messages in thread
From: Alexey Perevalov @ 2014-08-19 11:26 UTC (permalink / raw)
To: netfilter-devel; +Cc: Daniel Borkmann, pablo
On 08/18/2014 05:46 PM, Daniel Borkmann wrote:
> There's actually no good reason why we cannot use cgroup id 0,
> so lets just remove this artificial barrier.
>
> Reported-by: Alexey Perevalov <a.perevalov@samsung.com>
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
> ---
> net/netfilter/xt_cgroup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
Thank you, Daniel, I tested it on my environment, patch is fine.
Tested-by: Alexey Perevalov <a.perevalov@samsung.com>
--
Best regards,
Alexey Perevalov
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] netfilter: x_tables: allow to use default cgroup match
2014-08-19 11:26 ` Alexey Perevalov
@ 2014-08-19 19:39 ` Pablo Neira Ayuso
0 siblings, 0 replies; 3+ messages in thread
From: Pablo Neira Ayuso @ 2014-08-19 19:39 UTC (permalink / raw)
To: Alexey Perevalov; +Cc: netfilter-devel, Daniel Borkmann
On Tue, Aug 19, 2014 at 03:26:46PM +0400, Alexey Perevalov wrote:
> On 08/18/2014 05:46 PM, Daniel Borkmann wrote:
> >There's actually no good reason why we cannot use cgroup id 0,
> >so lets just remove this artificial barrier.
> >
> >Reported-by: Alexey Perevalov <a.perevalov@samsung.com>
> >Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
> >---
> > net/netfilter/xt_cgroup.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >
> Thank you, Daniel, I tested it on my environment, patch is fine.
>
> Tested-by: Alexey Perevalov <a.perevalov@samsung.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-19 19:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-18 13:46 [PATCH] netfilter: x_tables: allow to use default cgroup match Daniel Borkmann
2014-08-19 11:26 ` Alexey Perevalov
2014-08-19 19:39 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).