From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
netfilter-devel@vger.kernel.org
Subject: Re: [libnftnl PATCH] Rename xfree() to libnftnl_xfree() to avoid symbol naming conflict
Date: Wed, 20 Aug 2014 15:22:13 +0200 [thread overview]
Message-ID: <20140820132213.GA7106@salvia> (raw)
In-Reply-To: <alpine.LSU.2.11.1408201459330.23974@nerf08.vanv.qr>
On Wed, Aug 20, 2014 at 03:00:18PM +0200, Jan Engelhardt wrote:
> On Wednesday 2014-08-20 00:02, Pablo Neira Ayuso wrote:
>
> >On Sat, Aug 16, 2014 at 03:39:49PM +0200, Thomas Petazzoni wrote:
> >> [...] the xfree() symbols of libnftnl
> >> becomes visible to the outside world, causing a conflict with the
> >> xfree() symbol defined by nftables.
> >>
> >> To solve this, this patch renames the libnftnl xfree() function to
> >> libnftnl_xfree().
> >
> >Would this small patch solve your problem too?
> >
> >[non-inline attachment]
>
> It would, but why add the redundant cast?
free() makes gcc spot a warning when called with const objects.
prev parent reply other threads:[~2014-08-20 13:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-16 13:39 [libnftnl PATCH] Rename xfree() to libnftnl_xfree() to avoid symbol naming conflict Thomas Petazzoni
2014-08-19 22:02 ` Pablo Neira Ayuso
2014-08-20 12:07 ` Thomas Petazzoni
2014-08-20 13:00 ` Jan Engelhardt
2014-08-20 13:22 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140820132213.GA7106@salvia \
--to=pablo@netfilter.org \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).