From: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
To: netfilter-devel@vger.kernel.org
Cc: pablo@netfilter.org
Subject: [libnftnl PATCH 1/2] utils: ensure \0 is in place in nft_fprintf()
Date: Mon, 25 Aug 2014 15:02:21 +0200 [thread overview]
Message-ID: <20140825130221.23329.86583.stgit@nfdev.cica.es> (raw)
We must make sure the buffer contains a \0 in the last position,
to avoid printing trash by the last fprintf() call.
This is needed because if the internal snprintf callback prints nothing,
no \0 exists in the buffer.
Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
---
src/utils.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/utils.c b/src/utils.c
index 96c8bf2..8a7c521 100644
--- a/src/utils.c
+++ b/src/utils.c
@@ -189,6 +189,8 @@ int nft_fprintf(FILE *fp, void *obj, uint32_t type, uint32_t flags,
size_t bufsiz = sizeof(_buf);
int ret;
+ buf[0] = '\0';
+
ret = snprintf_cb(buf, bufsiz, obj, type, flags);
if (ret < 0)
goto out;
@@ -200,6 +202,8 @@ int nft_fprintf(FILE *fp, void *obj, uint32_t type, uint32_t flags,
if (buf == NULL)
return -1;
+ buf[0] = '\0';
+
ret = snprintf_cb(buf, bufsiz, obj, type, flags);
if (ret < 0)
goto out;
next reply other threads:[~2014-08-25 13:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-25 13:02 Arturo Borrero Gonzalez [this message]
2014-08-25 13:02 ` [libnftnl PATCH 2/2] src: improve printing of XML/JSON event wrapper header/footer Arturo Borrero Gonzalez
2014-08-25 14:12 ` Pablo Neira Ayuso
2014-08-25 14:09 ` [libnftnl PATCH 1/2] utils: ensure \0 is in place in nft_fprintf() Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825130221.23329.86583.stgit@nfdev.cica.es \
--to=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).