From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>,
netfilter-devel@vger.kernel.org
Subject: Re: nft option to flush out the existing ruleset [was Re: [libnftnl PATCH] examples: add nft-ruleset-replace]
Date: Tue, 26 Aug 2014 13:14:20 +0100 [thread overview]
Message-ID: <20140826121420.GA22955@acer.localdomain> (raw)
In-Reply-To: <20140826110954.GA5648@salvia>
On Tue, Aug 26, 2014 at 01:09:54PM +0200, Pablo Neira Ayuso wrote:
> Renaming the subject to make it to start a new discussion on something
> related. Cc'ing Patrick too, perhaps he can pull some better idea out
> of his hat.
>
> On Tue, Aug 26, 2014 at 11:57:16AM +0200, Arturo Borrero Gonzalez wrote:
> > This code examples uses the new NFT_MSG_DELTABLE functionality to replace
> > an entire ruleset in a single transaction/batch.
>
> Thanks for the example but we already have quite a lot of them, and
> this is yet another almost copy and paste that would need to be
> maintained.
>
> Please, implement this in nft. I think we can probably have an -x
> option, eg.
Agreed. The naive aproach seems to be something like this:
- add a generation ID to the ruleset
- dump the entire ruleset
- generate delete commands for each existing rule/chain/set...
- generate add commands for each new rule/chain/set...
- send the entire thing to the kernel, including the generation ID
- if the generation ID doesn't match, meaning the ruleset has changed
since the last dump, return an error to userspace, retry
next prev parent reply other threads:[~2014-08-26 12:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 9:57 [libnftnl PATCH] examples: add nft-ruleset-replace Arturo Borrero Gonzalez
2014-08-26 11:09 ` nft option to flush out the existing ruleset [was Re: [libnftnl PATCH] examples: add nft-ruleset-replace] Pablo Neira Ayuso
2014-08-26 12:14 ` Patrick McHardy [this message]
2014-08-26 13:12 ` Arturo Borrero Gonzalez
2014-08-26 13:30 ` Patrick McHardy
2014-08-26 13:47 ` Pablo Neira Ayuso
2014-08-26 14:35 ` Patrick McHardy
2014-08-26 13:38 ` Pablo Neira Ayuso
2014-09-01 15:07 ` Arturo Borrero Gonzalez
2014-09-01 15:17 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140826121420.GA22955@acer.localdomain \
--to=kaber@trash.net \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).