From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Alexey Perevalov <alexey.perevalov@hotmail.com>
Cc: Alexey Perevalov <a.perevalov@samsung.com>,
mathieu.poirier@linaro.org, netfilter-devel@vger.kernel.org,
kyungmin.park@samsung.com, hs81.go@samsung.com
Subject: Re: [[PATCH v3]] netfilter: nfnetlink_acct: add filter support to nfacct counter list/reset
Date: Tue, 26 Aug 2014 21:38:19 +0200 [thread overview]
Message-ID: <20140826193819.GA4757@salvia> (raw)
In-Reply-To: <BLU436-SMTP8877E9030BB0C55BBF4CC28DDC0@phx.gbl>
On Tue, Aug 26, 2014 at 11:15:04PM +0400, Alexey Perevalov wrote:
> Hi
> On 08/24/2014 05:15 PM, Pablo Neira Ayuso wrote:
> >Hi,
> >
> >On Wed, Aug 20, 2014 at 10:03:18PM +0400, Alexey Perevalov wrote:
> >>+static struct nfacct_filter *
> >>+nfacct_filter_alloc(struct nlattr *attrs[NFACCT_FILTER_MAX + 1])
> >>+{
> >>+ struct nfacct_filter *filter = kzalloc(sizeof(struct nfacct_filter),
> >>+ GFP_KERNEL);
> >>+ if (!filter)
> >>+ return ERR_PTR(-ENOMEM);
> >>+
> >>+ filter->mask = nla_get_be32(attrs[NFACCT_FILTER_MASK]);
> >>+ filter->value = nla_get_be32(attrs[NFACCT_FILTER_VALUE]);
> >We have to use ntohl() here, it's the convention for nfnetlink.
> >
> >I'm attaching a patch that resolves this plus some cleanups.
> >
> >Please, let me know if you're OK with it. Thanks.
>
> Yes, I'm ok with it.
Applied, thanks.
next prev parent reply other threads:[~2014-08-26 19:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 8:05 reset nfacct counters Alexey Perevalov
2014-07-25 16:01 ` Pablo Neira Ayuso
2014-07-25 16:39 ` Alexey Perevalov
2014-07-28 17:57 ` [PATCH] " Alexey Perevalov
2014-07-28 22:03 ` Pablo Neira Ayuso
2014-07-28 17:57 ` [PATCH] netfilter: nfnetlink_acct: use flag to reset counters Alexey Perevalov
2014-07-28 21:53 ` Pablo Neira Ayuso
2014-07-29 11:46 ` Alexey Perevalov
2014-07-29 16:32 ` Pablo Neira Ayuso
2014-07-29 21:00 ` Alexey Perevalov
2014-08-04 15:52 ` [PATCH] netfilter: nfnetlink_acct: add filter support to nfacct counter list/reset Alexey Perevalov
2014-08-04 15:52 ` Alexey Perevalov
2014-08-05 15:51 ` Pablo Neira Ayuso
2014-08-06 10:41 ` [PATCH v2] " Alexey Perevalov
2014-08-20 13:34 ` Pablo Neira Ayuso
2014-08-20 18:03 ` [[PATCH v3]] " Alexey Perevalov
2014-08-24 13:15 ` Pablo Neira Ayuso
2014-08-26 19:15 ` Alexey Perevalov
2014-08-26 19:38 ` Pablo Neira Ayuso [this message]
2014-08-26 19:24 ` Alexey Perevalov
2014-08-06 10:50 ` [PATCH] " Alexey Perevalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140826193819.GA4757@salvia \
--to=pablo@netfilter.org \
--cc=a.perevalov@samsung.com \
--cc=alexey.perevalov@hotmail.com \
--cc=hs81.go@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=mathieu.poirier@linaro.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).