netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] netfilter: fix missing dependencies in NETFILTER_XT_TARGET_LOG
@ 2014-09-02 12:26 Pablo Neira Ayuso
  2014-09-02 21:00 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Pablo Neira Ayuso @ 2014-09-02 12:26 UTC (permalink / raw)
  To: netfilter-devel; +Cc: davem, netdev

make defconfig reports:

warning: (NETFILTER_XT_TARGET_LOG) selects NF_LOG_IPV6 which has unmet direct dependencies (NET && INET && IPV6 && NETFILTER && NETFILTER_ADVANCED)

Fixes: d79a61d netfilter: NETFILTER_XT_TARGET_LOG selects NF_LOG_*
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
~
@David, if you pull this request:

http://patchwork.ozlabs.org/patch/385042/

Could you also manually apply this patch to calm down kbuild robot?

Thanks!

 net/ipv6/netfilter/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv6/netfilter/Kconfig b/net/ipv6/netfilter/Kconfig
index cf0b88f..2812816 100644
--- a/net/ipv6/netfilter/Kconfig
+++ b/net/ipv6/netfilter/Kconfig
@@ -57,7 +57,7 @@ config NFT_REJECT_IPV6
 
 config NF_LOG_IPV6
 	tristate "IPv6 packet logging"
-	depends on NETFILTER_ADVANCED
+	default m if NETFILTER_ADVANCED=n
 	select NF_LOG_COMMON
 
 config NF_NAT_IPV6
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] netfilter: fix missing dependencies in NETFILTER_XT_TARGET_LOG
  2014-09-02 12:26 [PATCH] netfilter: fix missing dependencies in NETFILTER_XT_TARGET_LOG Pablo Neira Ayuso
@ 2014-09-02 21:00 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-09-02 21:00 UTC (permalink / raw)
  To: pablo; +Cc: netfilter-devel, netdev

From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Tue,  2 Sep 2014 14:26:17 +0200

> make defconfig reports:
> 
> warning: (NETFILTER_XT_TARGET_LOG) selects NF_LOG_IPV6 which has unmet direct dependencies (NET && INET && IPV6 && NETFILTER && NETFILTER_ADVANCED)
> 
> Fixes: d79a61d netfilter: NETFILTER_XT_TARGET_LOG selects NF_LOG_*
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-09-02 21:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-02 12:26 [PATCH] netfilter: fix missing dependencies in NETFILTER_XT_TARGET_LOG Pablo Neira Ayuso
2014-09-02 21:00 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).