From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [nf_tables PATCH 4/6 v5] netfilter: nf_tables: add helpers to schedule objects deletion Date: Tue, 2 Sep 2014 17:47:08 +0200 Message-ID: <20140902154708.GA10540@salvia> References: <1409668946-8168-1-git-send-email-arturo.borrero.glez@gmail.com> <1409668946-8168-5-git-send-email-arturo.borrero.glez@gmail.com> <20140902152001.GD29716@acer.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Arturo Borrero Gonzalez , netfilter-devel@vger.kernel.org To: Patrick McHardy Return-path: Received: from mail.us.es ([193.147.175.20]:33591 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754102AbaIBPqT (ORCPT ); Tue, 2 Sep 2014 11:46:19 -0400 Content-Disposition: inline In-Reply-To: <20140902152001.GD29716@acer.localdomain> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Tue, Sep 02, 2014 at 04:20:01PM +0100, Patrick McHardy wrote: > On Tue, Sep 02, 2014 at 04:42:25PM +0200, Arturo Borrero Gonzalez wrote: > > This patch refactor the code to schedule objects deletion. > > > > They are useful in follow-up patches. > > > > In order to be able to use these new helper functions in all the code, > > they are placed in the top of the file, with all the dependant functions > > and symbols. > > > > Signed-off-by: Arturo Borrero Gonzalez > > --- > > v2: rebased: now, nft_del*() functions use list_del_rcu(). > > v3: rebased on top of patch 1/5. > > v4: The v3 version had several issues due to the rebase. Fixed in this v4. > > v5: no changes, resending the series. > > > > +static inline void > > +nft_rule_disactivate_next(struct net *net, struct nft_rule *rule) > > +{ > > + rule->genmask = (1 << gencursor_next(net)); > > +} > > Since you're touching this anyway please get rid of the disactivate here as > well and use deactivate consistently. Arturo, I can fix that here. That word I made up myself (which looks to Spanish...) was my fault after all :).