netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Holger Eitzenberger <holger@eitzenberger.org>
To: kadlec@blackhole.kfki.hu
Cc: netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH 5/5] ipset: data callback does not need to be part of cb_ctl[]
Date: Mon, 8 Sep 2014 17:26:48 +0200	[thread overview]
Message-ID: <20140908152648.GC16567@imap.eitzenberger.org> (raw)
In-Reply-To: <20140908143053.16930.68662.stgit@jonathan.eitzenberger.org>

Hi Jozsef,

> Because the data callback is passed explicitely to mnl_cb_run2()
> there is no need to add it to cb_ctl[].  For nlmsg_types
> >= NLMSG_MIN_TYPE the data callback is used explicitely.

Just noticed that there is a side effect to this one.  So please
just ignore this patch for now.

      reply	other threads:[~2014-09-08 15:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-08 14:30 [PATCH 0/5] ipset: some small userland improvements Holger Eitzenberger
2014-09-08 14:30 ` [PATCH 1/5] Remove a duplicate debug print Holger Eitzenberger
2014-09-14 19:08   ` Jozsef Kadlecsik
2014-09-08 14:30 ` [PATCH 2/5] ipset: avoid duplicate command flags Holger Eitzenberger
2014-09-14 19:09   ` Jozsef Kadlecsik
2014-09-08 14:30 ` [PATCH 3/5] ipset: coalesce two ifs Holger Eitzenberger
2014-09-14 19:10   ` Jozsef Kadlecsik
2014-09-08 14:30 ` [PATCH 4/5] ipset: remove extran newline on debug output Holger Eitzenberger
2014-09-14 19:11   ` Jozsef Kadlecsik
2014-09-08 14:30 ` [PATCH 5/5] ipset: data callback does not need to be part of cb_ctl[] Holger Eitzenberger
2014-09-08 15:26   ` Holger Eitzenberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140908152648.GC16567@imap.eitzenberger.org \
    --to=holger@eitzenberger.org \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).