Re: [nft RFC PATCH] src: add set optimization options

[Patrick McHardy <kaber@trash.net>]

On Fri, Sep 12, 2014 at 08:35:03PM +0200, Arturo Borrero Gonzalez wrote:
> On 3 September 2014 12:22, Patrick McHardy <kaber@trash.net> wrote:
> > On Wed, Sep 03, 2014 at 12:09:59PM +0200, Pablo Neira Ayuso wrote:
> >> Cc'ing Patrick.
> >>
> >> On Wed, Aug 13, 2014 at 10:17:06AM +0200, Arturo Borrero Gonzalez wrote:
> >> > This patch adds options to choose set optimization mechanisms.
> >> >
> >> > The syntax is one of:
> >> >
> >> >  nft add set filter set1 { type ipv4_addr size 1024 ; }
> >> >  nft add set filter set1 { type ipv4_addr policy memory ; }
> >> >  nft add set filter set1 { type ipv4_addr policy performance ; }
> >> >  nft add set filter set1 { type ipv4_addr policy memory size 1024 ; }
> >> >  nft add set filter set1 { type ipv4_addr size 1024 policy memory ; }
> >> >  nft add set filter set1 { type ipv4_addr policy performance size 1024 ; }
> >> >  nft add set filter set1 { type ipv4_addr size 1024 policy performance ; }
> >>
> >> @Patrick: Does this syntax look reasonable to you?
> >
> > I think I would prefer having statements instead of everything combined.
> >
> 
> Could you please elaborate on this?

Something like this:

{
	type ipve_addr
	size 1024
	policy performance
}

or seperate by colons in case they are on a single line.

> >> > Also valid for maps:
> >> >
> >> >  nft add map filter map1 { type ipv4_addr : verdict policy performace ; }

This gets a bit unreadable so { type ipv4_addr : verdict; policy performance; }
seems better to me.

> > This is what I have in my patchset:
> >
> > +struct set_desc {
> > +       unsigned int            size;
> > +       struct expr             *range;
> > +};
> >
> > Range is another way to express the maximum size and at the same time a
> > common prefix.
> >
> > I can dust off my patch and send it later so we combine what we have.
> 
> Would you send that patch?

Yep, just started to work on my tree five minutes ago. I'll forward-port
everything and will send the patch once I'm done.