From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Alexey Perevalov <a.perevalov@samsung.com>
Cc: alexey.perevalov@hotmail.com, netfilter-devel@vger.kernel.org,
kyungmin.park@samsung.com, hs81.go@samsung.com
Subject: Re: [PATCH v4 0/2] nfacct: add filter in to the list operation
Date: Mon, 15 Sep 2014 18:45:02 +0200 [thread overview]
Message-ID: <20140915164502.GA4705@salvia> (raw)
In-Reply-To: <1410519418-8671-1-git-send-email-a.perevalov@samsung.com>
On Fri, Sep 12, 2014 at 02:56:56PM +0400, Alexey Perevalov wrote:
> Hello Pablo,
>
> It's fourth version of patch for filtering, but also with fix for argument
> singleness.
Applied, thanks Alexey.
I have made also some mostly comestic changes on it:
- Avoid line break at 80 chars in strncmp(). We can replace strncmp by
a new function that takes only two parameters, then avoid the line
break.
- Removed NFACCT_F_QUOTAS, it's only used once. We can introduce this
later if we have more spots where we can use it.
- Rename quota-bytes to bytes-quota and quota-packets to pkts-quota.
The reason for this is that nfacct allows shortened syntax, eg.
nfacct l r
which is actually 'list reset'. By swapping the words, we can now use:
nfacct l r p
which only resets packet-based quotas.
next prev parent reply other threads:[~2014-09-15 16:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 10:56 [PATCH v4 0/2] nfacct: add filter in to the list operation Alexey Perevalov
2014-09-12 10:56 ` [PATCH v4 1/2] nfacct: check cmd line argument for singleness Alexey Perevalov
2014-09-12 10:56 ` [PATCH v4 2/2] nfacct: add filter in to the list operation Alexey Perevalov
2014-09-15 16:45 ` Pablo Neira Ayuso [this message]
2014-09-16 7:08 ` [PATCH v4 0/2] " Alexey Perevalov
2014-09-16 17:33 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915164502.GA4705@salvia \
--to=pablo@netfilter.org \
--cc=a.perevalov@samsung.com \
--cc=alexey.perevalov@hotmail.com \
--cc=hs81.go@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).