From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Rob Jones <rob.jones@codethink.co.uk>
Cc: netfilter-devel@vger.kernel.org, linux-kernel@codethink.co.uk
Subject: Re: [PATCH] net/netfilter/x_tables.c: use __seq_open_private()
Date: Tue, 23 Sep 2014 16:02:37 +0200 [thread overview]
Message-ID: <20140923140237.GA27307@salvia> (raw)
In-Reply-To: <1411122471-20087-1-git-send-email-rob.jones@codethink.co.uk>
On Fri, Sep 19, 2014 at 11:27:51AM +0100, Rob Jones wrote:
> Reduce boilerplate code by using __seq_open_private() instead of seq_open()
> in xt_match_open() and xt_target_open().
>
> Signed-off-by: Rob Jones <rob.jones@codethink.co.uk>
> ---
>
> This patch uses an existing variant of seq_open() to reduce the kernel code
> size.
Less code to maintain, good.
> The only significant variation from the pre-existing code is the fact that
> __seq_open_private() calls kzalloc() rather than kmalloc(), which could
> conceivably have an impact on timing.
I think you can skip
trav->class = MTTG_TRAV_INIT;
too, now that trav is set to zero.
next prev parent reply other threads:[~2014-09-23 14:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 10:27 [PATCH] net/netfilter/x_tables.c: use __seq_open_private() Rob Jones
2014-09-23 14:02 ` Pablo Neira Ayuso [this message]
2014-09-23 15:32 ` Rob Jones
2014-09-23 15:36 ` Pablo Neira Ayuso
2014-09-23 15:38 ` Rob Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923140237.GA27307@salvia \
--to=pablo@netfilter.org \
--cc=linux-kernel@codethink.co.uk \
--cc=netfilter-devel@vger.kernel.org \
--cc=rob.jones@codethink.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).