From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org, kaber@trash.net
Subject: Re: [nft PATCH 1/2] rule: factorize chain and table listing code
Date: Wed, 24 Sep 2014 11:49:56 +0200 [thread overview]
Message-ID: <20140924094956.GA4900@salvia> (raw)
In-Reply-To: <20140924091351.13585.92650.stgit@nfdev.cica.es>
On Wed, Sep 24, 2014 at 11:13:51AM +0200, Arturo Borrero Gonzalez wrote:
> Let's factorize common code. This is also useful in follow-up patches.
>
> Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
> ---
> src/rule.c | 67 +++++++++++++++++++++++++++++++-----------------------------
> 1 file changed, 35 insertions(+), 32 deletions(-)
>
> diff --git a/src/rule.c b/src/rule.c
> index 2fe2520..ac72f12 100644
> --- a/src/rule.c
> +++ b/src/rule.c
> @@ -749,11 +749,42 @@ static void do_command_list_cleanup(struct table *table)
> }
> }
>
> +static int do_command_list_table_content(struct netlink_ctx *ctx,
> + struct cmd *cmd, struct table *table)
I prefer a slightly shorter name: do_list_table.
do_command_list_cleanup can probably be renamed to table_cleanup since
it has nothing to do with the commands.
next prev parent reply other threads:[~2014-09-24 9:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 9:13 [nft PATCH 1/2] rule: factorize chain and table listing code Arturo Borrero Gonzalez
2014-09-24 9:13 ` [nft PATCH 2/2] src: add list ruleset command Arturo Borrero Gonzalez
2014-09-24 9:58 ` Pablo Neira Ayuso
2014-09-24 9:49 ` Pablo Neira Ayuso [this message]
2014-09-29 10:37 ` [nft PATCH 1/2] rule: factorize chain and table listing code Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140924094956.GA4900@salvia \
--to=pablo@netfilter.org \
--cc=arturo.borrero.glez@gmail.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).