From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org, alvaroneay@gmail.com
Subject: Re: [libnftnl PATCH 2/2] examples: nft-set-parse-add: give batching support
Date: Mon, 29 Sep 2014 17:03:23 +0200 [thread overview]
Message-ID: <20140929150323.GA4591@salvia> (raw)
In-Reply-To: <20140926183448.3333.64808.stgit@nfdev.cica.es>
On Fri, Sep 26, 2014 at 08:34:48PM +0200, Arturo Borrero Gonzalez wrote:
> @@ -66,6 +67,8 @@ static struct nft_set *set_parse_file(const char *file, uint16_t format)
> }
>
> nft_parse_err_free(err);
> +
> + nft_set_attr_set_u32(s, NFT_SET_ATTR_ID, 1);
> return s;
>
> }
I guess this works if you parse one single set definition in a file.
With more than one set, this will break.
IIRC, Alvaro started a patch time ago to add a new interface to
libnftnl to handle the set internal id which was incomplete.
Cc'ing him to know its status.
next prev parent reply other threads:[~2014-09-29 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 18:34 [libnftnl PATCH 1/2] examples: nft-set-json-add: generalize parsing format support Arturo Borrero Gonzalez
2014-09-26 18:34 ` [libnftnl PATCH 2/2] examples: nft-set-parse-add: give batching support Arturo Borrero Gonzalez
2014-09-29 15:03 ` Pablo Neira Ayuso [this message]
[not found] ` <CAOkSjBhujE4fx-1YnH1ZqdP1aUsZxaPQR+rrXoLC6wBBbONjYg@mail.gmail.com>
2014-09-30 9:03 ` Pablo Neira Ayuso
2014-09-29 14:58 ` [libnftnl PATCH 1/2] examples: nft-set-json-add: generalize parsing format support Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140929150323.GA4591@salvia \
--to=pablo@netfilter.org \
--cc=alvaroneay@gmail.com \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).