From: David Miller <davem@davemloft.net>
To: pablo@netfilter.org
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
eric.dumazet@gmail.com, therbert@google.com, fw@strlen.de
Subject: Re: [PATCH net-next] netfilter: bridge: build br_nf_core only if required
Date: Tue, 30 Sep 2014 14:10:01 -0400 (EDT) [thread overview]
Message-ID: <20140930.141001.265442216668830904.davem@davemloft.net> (raw)
In-Reply-To: <1412067559-28733-1-git-send-email-pablo@netfilter.org>
From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Tue, 30 Sep 2014 10:59:18 +0200
> From: Florian Westphal <fw@strlen.de>
>
> Eric reports build failure with
> CONFIG_BRIDGE_NETFILTER=n
>
> We insist to build br_nf_core.o unconditionally, but we must only do so
> if br_netfilter was enabled, else it fails to build due to
> functions being defined to empty stubs (and some structure members
> being defined out).
>
> Also, BRIDGE_NETFILTER=y|m makes no sense when BRIDGE=n.
>
> Fixes: 34666d467 (netfilter: bridge: move br_netfilter out of the core)
> Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: Florian Westphal <fw@strlen.de>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Applied, thanks.
prev parent reply other threads:[~2014-09-30 18:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 8:59 [PATCH net-next] netfilter: bridge: build br_nf_core only if required Pablo Neira Ayuso
2014-09-30 18:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140930.141001.265442216668830904.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).