Re: [PATCH lnfct] qa: build unshared nfct environment

[Florian Westphal <fw@strlen.de>]

Ken-ichirou MATSUZAWA <chamaken@gmail.com> wrote:
> nssocket forks and change netns pre-establishd by ip(8), serves its
> socket descriptor to parent via nssocket().  Since this socket is
> isolated, it can be used to create regression tests for conntrack.
> 
> This also adds a conntrack event testcase as a first user.
> A ct_echo_event.sh script is provided to build and run this test
> automatically:
> 
>   # ./qa/ct_echo_event.sh
>   make: Entering directory...
>   ...debug output like:
>       [NEW] tcp      6 2 SYN_SENT src=10.255.255.249 dst=10.255.255.250 sport...
>    [UPDATE] tcp      6 2 SYN_RECV src=10.255.255.249 dst=10.255.255.250 sport...
>   ...
>   [DESTROY] icmp     1 src=10.255.255.249 dst=10.255.255.250 type=8 code=0...
>   # echo $?
>   0

make: Entering directory `git/netfilter.org/libnetfilter_conntrack/qa'
  CC       ct_echo_event.o
ct_echo_event.c:231:12: warning: 'cb_tcp_last_ack' defined but not used [-Wunused-function]
ct_echo_event.c:241:12: warning: 'cb_tcp_time_wait' defined but not used [-Wunused-function]
ct_echo_event.c:251:12: warning: 'cb_tcp_after_finwait' defined but not used [-Wunused-function]
  CCLD     ct_echo_event
make: Leaving directory `git/netfilter.org/libnetfilter_conntrack/qa'
modprobe: FATAL: Module nfnetlink_cttimeout not found.
(UNKNOWN) [10.255.255.250] 7 (echo) : Connection refused
    [NEW] tcp      6 2 SYN_SENT src=10.255.255.249 dst=10.255.255.250 sport=55576 dport=7 [UNREPLIED] src=10.255.255.250 dst=10.255.255.249 sport=7 dport=55576
[DESTROY] tcp      6 src=10.255.255.249 dst=10.255.255.250 sport=55576 dport=7 [UNREPLIED] src=10.255.255.250 dst=10.255.255.249 sport=7 dport=55576
ct_echo_event: ct_echo_event.c:95: author_update: Assertion `(nlh->nlmsg_type & 0xFF) == IPCTNL_MSG_CT_NEW' failed.
qa/ct_echo_event.sh: line 56:  2182 Aborted                 ${dname}/ct_echo_event $NETNS $PRE_FIFO $POST_FIFO
qa/ct_echo_event.sh: line 62: qa_post_fifo: No such file or directory
qa/ct_echo_event.sh: line 65: qa_pre_fifo: No such file or directory
qa/ct_echo_event.sh: line 67: qa_post_fifo: No such file or directory
qa/ct_echo_event.sh: line 70: qa_pre_fifo: No such file or directory
qa/ct_echo_event.sh: line 72: qa_post_fifo: No such file or directory
Killed

Seems like this depends on inetd to provide tcp/udp echo services.
Thats fine, I don't have any objections.

The ICMP test passes when I remove tcp/udp test.

Could you please either remove the unused functions or provide some
comment in the commit message why these helpers are there, but currently
unused? (I see you commented out the calls).

[ the modprobe error is because I don't have cttimeout but it does appear to have no immediate
 ill effect ]

Thanks!